⚠️ Remove default resource limits #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel7born
changed the title
timebertt
changed the title
timebertt
reviewed
Jun 7, 2024
axel7born
force-pushed
the
remove-resources-from-values
branch
from
62c7bf3 to
ddc989d
Compare
timebertt
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ControllerDeployment.We propose to set the resources field in the values.yaml file to an empty map. This change would align with the configuration used in other Gardener extensions. We've encountered issues specifically related to the CPU limit, which we prefer not to set. With the current configuration, it's not possible to delete the CPU limit once it's set; we can only increase its value. By setting resources to an empty map, we can avoid this issue and provide more flexibility in resource configuration.