chore: move tools to a separated module #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
force-pushed
the
move_tools_to_a_new_module
branch
from
c753769 to
99490d8
Compare
janisz
commented
Jul 18, 2024
| @@ -1,5 +1,7 @@ | |||
| .PHONY: deps | |||
There was a problem hiding this comment.
This was a mistake we create a file here
janisz
commented
Jul 18, 2024
| @@ -10,5 +10,4 @@ package toolimports | |||
| import ( | |||
| _ "github.com/golangci/golangci-lint/cmd/golangci-lint" | |||
| _ "github.com/goreleaser/goreleaser" | |||
| _ "k8s.io/cli-runtime/pkg/resource" // This is imported because we want to be able to require it at a certain version, since otherwise Helm breaks. | |||
There was a problem hiding this comment.
let's see if we really need it
stehessel
approved these changes
Jul 23, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External tools pollute
go.modand make it harder to update project. In this PR new module is created for golangci-lint and goreleaser and Go is updated to 1.22.5