-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Commit window fixes #2177
Commit window fixes #2177
Conversation
…es to block processing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but please add the bitmask in the block-commit before merging. Thanks!
… appear to run consistently in gh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR addresses #2141, by introducing a "burn parent modulus" to allow the stacks-node to detect when a commitment may be missed. This PR also updates the smoothing function to:
Which is less punitive than
mean(min, median)
Type of Change
Does this introduce a breaking change?
Yes, this changes the wire format for block commits (change is documented in SIP-001), which would lead to a consensus-breaking change.
Documentation updates are probably required -- any mining references we have should be updated to reflect that the smoothing function is changing from
mean(min, median)
tomin(last_burn, median)
Testing information
There's a few different ways that this is tested:
distribution
are unit tested in that module.cfg(test)
enabled storage of burn distributions so that the evaluated distribution could be checked after a burn block is processed.