Fix: address #2358

[friedger]

Description

SIP-007 describes that the smoothing function takes the previous 6 bitcoin commits as burn samples.
However, the current implementation tries to use a block that in most cases is in the future.

This PR fixes this by using the block as described in SIP-007
For details refer to issue #2358

TODOs:

• Integration test to cover the error MissedBlockCommit needs to be added
• Does this require a new SIP?
• Should be rebased to blockstack:next after Merge develop into next #2373 merged

Type of Change

• New feature
• Bug fix
• API reference/documentation update
• Other

Does this introduce a breaking change?

Consensus breaking

Are documentation updates required?

No

Testing information

• Run unit tests (only covering parts of the changed code)

Checklist

• Code is commented where needed
• Unit test coverage for new or modified code paths
• npm run test passes
• Changelog is updated
• Tag 1 of @kantai

[jcnelson]

Hey @friedger, because this is consensus-breaking, it should be opened against next.

[jcnelson]

This is blocked on #2464

[jcnelson]

This feature has been implemented and superseded by #3110

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.