Fix picker validation #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the condition to run the onError handler within pickers so they don't remove validation errors coming from fields
michaldudak
commented
May 19, 2020
|
|
||
| export function createErrorHandler(fieldError: unknown, fieldName: string, setFieldError: (field: string, message: string) => void) { | ||
| return (error : ReactNode) => { | ||
| if (error !== fieldError && error !== '') { |
There was a problem hiding this comment.
This is where the meaningful change is: I removed the && !fieldError from condition. In cases where there was a validation error coming from Formik, error is empty and fieldError has value. Then setFieldError would incorrectly fire and set the field error to undefined (effectively breaking the validation).
|
Awesome work, hopefully this will be merged soon. |
This was referenced Jun 24, 2020
cliedeman
approved these changes
Jun 24, 2020
This was referenced Jun 6, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the condition to run the
onErrorhandler within pickers so they don't remove validation errors coming from fields.Extracted the error handler to a separate function to reduce repetition.