Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Synced android and ios navigation state, refactored NavigationViewModel #167

Merged
merged 15 commits into from
Jul 31, 2024

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Jul 30, 2024

  • Updates ferrostar rust server to 0.6.0
  • Includes breaking changes to FerrostarCore init, NavigationViewModel and others.
  • Refactors iOS NavigationState to rely on TripState like Android.
  • Adds NavigationControllerConfig set on FerrostarCore init.
  • Adds Idle to TripState to allow presetting value for android dependency injection. This allows us to properly construct the StateFlow at app launch.
  • Revises startNavigation to override config optionally.
  • Refactors NavigationViewModel for better dependency injection.

@Archdoog Archdoog changed the title Synced android and ios navigation state, refactored NavigationViewMod… Synced android and ios navigation state, refactored NavigationViewModel Jul 30, 2024
@ianthetechie ianthetechie self-requested a review July 30, 2024 06:25
@Archdoog Archdoog marked this pull request as ready for review July 30, 2024 16:22
@ianthetechie ianthetechie merged commit fc34201 into main Jul 31, 2024
14 checks passed
@ianthetechie ianthetechie deleted the fix/align-nav-state branch July 31, 2024 02:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants