Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added fixed version footer #104

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Conversation

colfax23
Copy link
Contributor

@colfax23 colfax23 commented Nov 4, 2021

Screen Shot 2021-11-04 at 6 23 04 PM

@colfax23 colfax23 requested a review from remyroy November 4, 2021 22:23
@colfax23
Copy link
Contributor Author

colfax23 commented Nov 4, 2021

Completes #87

@remyroy remyroy linked an issue Nov 4, 2021 that may be closed by this pull request
Copy link
Member

@remyroy remyroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails to build with a bunch of:

TS2307: Cannot find module '../components/VersionFooter' or its corresponding type declarations.

Did you forget to add the VersionFooter.tsx file?

Copy link
Member

@remyroy remyroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The footer that includes the version number and the commit hash seems to be moving from step to step. It might just be slightly different or misaligned when you compare the home page to the wizard pages. It seems to jump to the right a little after clicking on the first button.

@colfax23
Copy link
Contributor Author

colfax23 commented Nov 5, 2021

Good spot. Fixed.

@remyroy
Copy link
Member

remyroy commented Nov 5, 2021

Looks good now. Ready to merge.

@colfax23 colfax23 merged commit 5e94c87 into stake-house:main Nov 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display version number in UI
2 participants