Use BASE64_MIME_PERMISSIVE to allow trailing bits in b64 data #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'd like to wait until the new version of data encoding is published before merging this. I'll try to check periodically but if you ping here once it's published that would be great and I can merge this. |
|
With ia0/data-encoding#104 version 2.6.0 of data-encoding has been published to https://crates.io/crates/data-encoding I believe this PR is now safety mergable. |
|
Ah oops I accidentally closed closed this by pushing the wrong branch. I just wanted to squash the commits. Hang on a sec |
|
Let's try this... |
|
Ok I just made a new PR, #126 with the squashed commit. I've retained your authorship on the commit there. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #96
Note, this requires a not yet released https://github.com/ia0/data-encoding and shouldn't be submitted until data-encoding v2.6.0 is released. Please let me know if there's a better way to deal with an upstream feature that is currently only in git (for example, if you want me to update the Cargo.toml to depend on a git repo instead of the crate).
Alos, I'm happy to wait until v2.6.0 is released.