ba-Feat/badge bot test

[tobi-bams]

No description provided.

[kevkevinpal]

maybe adding functionality to use /badge create ...badge_args would be cool so we don't need to wait for a frontend to be built

[kevkevinpal]

@tobi-bams to test add -b add_bolt here to get the test running using the correct branch and if it works we should be good to merge the sphinx-stack changes and the change it back to master and then merge this change

https://github.com/stakwork/sphinx-relay/pull/502/files#diff-2289f323d1e30f0ec6781fe565465798b0be9d8facf72fad2bd5701e0357a885R64

[tobi-bams]

@kevkevinpal yeah, we could use that branch, but for now, the test would still fail because the liquid server is not allowing us to create badges.
We also need to update the boltwall image in Docker Hub

[kevkevinpal]

@tobi-bams do you know if the boltwall container is calling the actual sphinx-liquid server?

[tobi-bams]

@tobi-bams do you know if the boltwall container is calling the actual sphinx-liquid server?

Yes it is calling the actual sphinx-liquid server

[kevkevinpal]

@tobi-bams do you know if the boltwall container is calling the actual sphinx-liquid server?

Yes it is calling the actual sphinx-liquid server

Hmm if that's the case then it doesn't make sense to do that in the testing env because then we'll run out of sats very quickly since we're running these test for every PR

it seems like either we need to get a mock response somehow coming from the sphinx-liquid server or get the liquid server working on regtest on sphinx-stack which might be difficult considering it needs the liquid sidechain

[tobi-bams]

@tobi-bams do you know if the boltwall container is calling the actual sphinx-liquid server?

Yes it is calling the actual sphinx-liquid server

Hmm if that's the case then it doesn't make sense to do that in the testing env because then we'll run out of sats very quickly since we're running these test for every PR

it seems like either we need to get a mock response somehow coming from the sphinx-liquid server or get the liquid server working on regtest on sphinx-stack which might be difficult considering it needs the liquid sidechain

Yea I agree, I would suggest we go with a mock response

[kevkevinpal]

I'm thinking if it might take a while to include mock responses to sphinx-stack we might want to do extensive unit testing to get this feature going quicker

you can find the unit tests here

https://github.com/stakwork/sphinx-relay/tree/master/src/tests/unit_tests

[Evanfeenstra]

Nice job creating tests for it @tobi-bams!. What is you plan to add mocks?

I think you need some more validation in places. Like after const amount = Number(arr[3]) you can check if (!amount) then return a failure text message like "Invalid amount"

Also a good idea to include a /badge help command that returns some help text (like what order the arguments are in)

[tobi-bams]

Thanks @Evanfeenstra,
I would be using Mockable.io to mock responses from the liquid server and add this endpoint to the boltwall environment variable.

I would add those extra validations thanks.

In regards to the /badge help I have that already