Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat/fee test #708

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Feat/fee test #708

merged 7 commits into from
Jun 28, 2023

Conversation

tobi-bams
Copy link
Contributor

No description provided.

@tobi-bams tobi-bams requested a review from Evanfeenstra June 14, 2023 01:08
@tobi-bams tobi-bams linked an issue Jun 14, 2023 that may be closed by this pull request
@Evanfeenstra
Copy link
Contributor

why 18 for time_lock_delta?

@tobi-bams
Copy link
Contributor Author

why 18 for time_lock_delta?

18 is the minimum, also you can't update channel policy with RPC without updating the time_lock_delta by default it is 0.

Lastly, I built this endpoint for the test majorly.

@Evanfeenstra
Copy link
Contributor

@tobi-bams I pushed a docker image sphinx-proxy:0.1.34-log-fee-limit with more logs to figure out what the problem is with CLN fees

Can you run that locally and read the sphinx-proxy logs? There should be one log line with router send: showing FeeLimitSat/FeeLimitMsat and another with SEND PAY REQ showing CLN Maxfeepercent

@tobi-bams
Copy link
Contributor Author

router send: dest:"\x03d\xc0\\\xbc\xbb\x96\x12\x03l\xc6b\x97DZ\x88\xbc\xfc!\x94\x1f\xd8\x16\xe1zV\xb5K\x0bR\xff\x02\xb9" amt:80 payment_hash:"d\x07\x1dj\x10c}\x11%\x92;\xddE ,\xc8\xf4\xe2\x17\tĈ\x9a\xfe\xdb=[}\xfcA\xc9W" final_cltv_delta:141 timeout_seconds:16 fee_limit_sat:21 dest_custom_records:{key:133773310 value:"{\"type\":28}rb8zinogj3wgucw4ttgw3iek11k3nni684w7yhtagtf1914ofazgcicor5ca5uoj5g6icp3b8qaejmc31qjffuxeqemf56k3g9hjg5r8"} dest_custom_records:{key:5482373484 value:"UDK\x19\xbbe\x8fr\xba\xbe?\x0eʻ3O/ e\x84\xab\r\x01\x85\x9e\xf8\x9a\x9c\xca\xf9\x13\xcb"} dest_features:TLV_ONION_OPT

SEND PAY REQ destination:"\x03d\xc0\\\xbc\xbb\x96\x12\x03l\xc6b\x97DZ\x88\xbc\xfc!\x94\x1f\xd8\x16\xe1zV\xb5K\x0bR\xff\x02\xb9" amount_msat:{msat:80000} label:"c7190fbcea205eddd358e5f25ae70647" extratlvs:{entries:{type:133773310 value:"{\"type\":28}rb8zinogj3wgucw4ttgw3iek11k3nni684w7yhtagtf1914ofazgcicor5ca5uoj5g6icp3b8qaejmc31qjffuxeqemf56k3g9hjg5r8"}}
finalizeRemoteInvoice err rpc error:code = Unknown desc = Error calling method KeySend: RpcError { code: Some(210), message: "Ran out of routes to try after 2 attempts: seepaystatus" }

@Evanfeenstra
Copy link
Contributor

@tobi-bams i think i finally found the bug, can you try sphinx-proxy:0.1.34-log-fee-limit-2

@tobi-bams
Copy link
Contributor Author

tobi-bams commented Jun 27, 2023

@tobi-bams i think i finally found the bug, can you try sphinx-proxy:0.1.34-log-fee-limit-2

@Evanfeenstra This solved it, the test is passing now.

@Evanfeenstra Evanfeenstra merged commit ae5ca4c into master Jun 28, 2023
@kevkevinpal kevkevinpal deleted the feat/fee_test branch August 24, 2023 13:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

routing fees tests
2 participants