Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Filesystem improvements #115

Merged
merged 11 commits into from
Dec 25, 2019
Merged

Filesystem improvements #115

merged 11 commits into from
Dec 25, 2019

Conversation

allejo
Copy link
Member

@allejo allejo commented Dec 24, 2019 •
edited
Loading

Summary

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed issues N/A

Description

Lots of improvements to the way we work with the filesystem at stakx's core.

  • Adds new WritableFolder to replace Folder
  • Creates a Folder class to represent folders on the filesystem
  • Add support for custom matchers in the FileExplorer class
  • Adds new FileExplorerDefinition for creating FileExplorer instances
  • Add modifiedAfter FileExplorer matcher
  • Add support for accessing MIME types of files

Check List

  • Added appropriate PhpDoc for modifications
  • Added unit test to ensure fix works as intended

@allejo allejo added the Feature: Enhancement The feature already exists but this is a request for it to be improved label Dec 24, 2019
@allejo allejo merged commit 9d745ac into develop Dec 25, 2019
@allejo allejo deleted the feature/filesystem-improvements branch December 25, 2019 00:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature: Enhancement The feature already exists but this is a request for it to be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@allejo