Allow Sass Static PageViews to recompile themselves #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allejo
added
WIP
Core: Non-breaking
allejo
changed the title
allejo
changed the title
The following two events: - CompileProcessPostRenderPageView - CompileProcessPreRenderPageView have been split up into more targeted events containing more useful information such as the current PageView and relevant information to the PageView such current ExpandedValue or CollectableItem: - CompileProcessPostRenderDynamicPageView - CompileProcessPostRenderRepeaterPageView - CompileProcessPostRenderStaticPageView - CompileProcessPreRenderDynamicPageView - CompileProcessPreRenderRepeaterPageView - CompileProcessPreRenderStaticPageView This is not a backwards compatible change.
allejo
force-pushed
the
hotfix/diff-sass-event
branch
from
9f1da0d to
4001093
Compare
Extend the original Sass compiler with a custom version that supports being reused so the dev server can serve updated Sass on reload without having to reparse all of the Sass and take advantage of the existing internal cache.
allejo
added
Core: Breaking
allejo
force-pushed
the
hotfix/diff-sass-event
branch
from
d793f5a to
af4608f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
Instead of calling the Scss compiler when the
PageManagerPostProcessevent is fired, call it when theCompilerPostRenderStaticPageViewevent is called; this event is called every time the Static PageView has been requested to be compiled.Changes
A large change in this PR is that
CompileProcessPostRenderPageViewandCompileProcessPreRenderPageViewhas been split up into specialized events for each PageView type with more useful information with regards to which PageView is actually being compiled. This change breaks BC but since 0.2.0 is still in alpha, it's safe to break.Check List