New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix process_init_approx #984

Merged

andrjohns merged 1 commit into master from process_init_approx_fix

May 24, 2024

Member

avehtari commented May 24, 2024

When using approximate inference algorithm fit objects as init there could be some errors that this PR fixes

Issue: lp__ or lp_approx__ may contain NaN. NA, or Inf. Fix: replace non-finite lw with -Inf
Issue: pareto_smooth() was estimating r_eff, but for independent draws from approximate normals r_eff=1 should be used: Fix: add argument r_eff=1 to pareto_smooth() call


          fix process_init_approx

da28415

avehtari requested a review from andrjohns

May 24, 2024 08:39

andrjohns reviewed

View reviewed changes

Collaborator

andrjohns left a comment

Thanks! Looks good, just one question

R/args.R Show resolved Hide resolved

andrjohns merged commit 1679aa7 into master

11 checks passed

andrjohns deleted the process_init_approx_fix branch

May 24, 2024 11:08

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet