fix: usage of ES2022 features #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already set our `peerDependencies` to use ESLint `^8.8.0` anyway.
theoludwig
force-pushed
the
fix/usage-of-2022-features
branch
from
2be454c to
0e26adb
Compare
voxpelli
reviewed
Feb 3, 2022
voxpelli
approved these changes
Feb 3, 2022
|
🎉 Congrats on getting your first pull request landed! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
set
"parserOptions.ecmaVersion": 2022Which issue (if any) does this pull request address?
Fixes #43
Is there anything you'd like reviewers to focus on?
The fix suggested that we remove completely
paserOptions, but we should be more conservative, maybe there are people using this package alone withouteslint-config-standard?Also, it might be the last release of this package in favor of #21, which opened in 2017, I think it will be time to actually do this for the next iteration (not for
standard@17but probably forstandard@18next year).I would say that removing
parserOptionsshould be fine but as the current state of nearly EOL of this package, it makes sense to not break too much, of course, feel free to disagree and to discuss. 😄Another small thing, I removed ESLint v7 testing in CI as tests were failing, and we already set our
peerDependenciesto only support ESLint"^8.8.0"anyway.