-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[New RM] Add AzureAISearch #198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaoyijia
requested changes
Oct 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for your contribution! We are happy to integrate this once you fix the nits.
@shaoyijia requested changes have been applied |
shaoyijia
approved these changes
Oct 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this!
feldges
pushed a commit
to feldges/storm
that referenced
this pull request
Dec 4, 2024
[New RM] Add AzureAISearch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add RM support for Azure AI Search. Allows the use of custom datasets made available through Azure AI Search.
Changes
requirements.txt
to includeazure-search-documents
. This SDK wraps Azure's AI Search functionality.rm.py
to includeAzureAISearch
implementation.run_storm_wiki_gpt.py
, to includeAzureAISearch
support.README.md
to include the new retrieval module componentChange Questions / Comments
We could do something akin to what was done for Google Search support: rather than install as part of
requirements.txt
, have the RM fail unless the user installs the proper pypi library.Generated Files
I've attached a zip of the artifacts generated running the
run_storm_wiki_gpt.py
using the new rm. Data for the article sourced from part of dFusion's Genesis Knowledge Pool made available through Azure AI Search. Files in the zip include:Formal_Verification_In_Smart_Contract_Development.tar.gz