Skip to content

Quote Annotation - AnnotationException StringIndexOutOfBoundsException #1147

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
allenkim opened this issue Apr 5, 2021 · 29 comments
Closed

Comments

@allenkim
Copy link

allenkim commented Apr 5, 2021

Hello,

I had a situation with text that had this: ""=

It seems to throw an error when I try running the pipeline with quote annotation on this small fragment. Just wanted to verify that it was an issue.

Thank you.

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 6, 2021 via email

@allenkim
Copy link
Author

allenkim commented Apr 7, 2021

I tried running CoreNLP with the new files in the zip, but am still getting the same errors...

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 7, 2021 via email

@allenkim
Copy link
Author

allenkim commented Apr 7, 2021

Just running the pipeline on the given text ""= seems to create errors for me when including the quote pipeline. Hopefully, I'm not running something incorrectly.

@AngledLuffa
Copy link
Contributor

Alright, I see a bug and a potential fix using that example. I posted a new release candidate at the same address. Want to try again?

http://downloads.cs.stanford.edu/nlp/software/stanford-corenlp-4.2.1.zip

@allenkim
Copy link
Author

allenkim commented Apr 7, 2021

Thanks. It seems to work for that example, but here is another example that seems to cause issues: "?'" AAAAA BBBBB

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 7, 2021 via email

@allenkim
Copy link
Author

allenkim commented Apr 7, 2021

I seem to still be getting the same error for the "?'" AAAAA BBBBB example. Was the same link updated?

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 7, 2021 via email

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 7, 2021 via email

@allenkim
Copy link
Author

allenkim commented Apr 8, 2021

Seemed to fix that issue, but I found another (sorry to keep bombarding you like this). They all seem to be under this index out of bounds error.

This one is a larger piece of text, so I attached a text file.

excerpt.txt

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 8, 2021 via email

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 10, 2021 via email

@AngledLuffa
Copy link
Contributor

PS we hope to make a new release in a week or two, with these changes being part of the updates, so please don't hesitate to send us any more errors you find

@allenkim
Copy link
Author

Thanks! This seems to close out the issues I see so far, but I'll keep this open for a bit in case more errors pop up.

@allenkim
Copy link
Author

Here's another error I'm getting; something with NullPointerException.

passage.txt

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 13, 2021 via email

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 13, 2021 via email

@allenkim
Copy link
Author

Wow, that was fast! It's amazing how quickly you pick up on these things! Much appreciated. Seems good so far.

Again, will let you know if anything else is a problem.

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 14, 2021 via email

@allenkim
Copy link
Author

Here's another passage with a bug:

passage.txt

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 15, 2021 via email

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 17, 2021 via email

@allenkim
Copy link
Author

No crashes so far! Looks like the latest changes are working well!

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 18, 2021 via email

@allenkim
Copy link
Author

Here's another snippet of text that raises an error I found.

snippet.txt

@AngledLuffa
Copy link
Contributor

AngledLuffa commented Apr 28, 2021 via email

@AngledLuffa
Copy link
Contributor

Alright, I put together a more official release including all of the QuoteAnnotator fixes. Please let us know if you find more & we'll start including them for the next version. Otherwise, shall we consider this resolved?

@allenkim
Copy link
Author

allenkim commented May 5, 2021

Yes. Sounds good. I'll let you know if more errors are found, but in the meantime, I appreciate the fixes and we can close this now.

@allenkim allenkim closed this as completed May 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants