-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Quote Annotation - AnnotationException StringIndexOutOfBoundsException #1147
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Would you try this? It's not an official release, just a zip of all the
recent changes we've made. Note that the current release of the
shift-reduce models won't work with this. If you need those, I'll send you
a link for that as well.
http://downloads.cs.stanford.edu/nlp/software/stanford-corenlp-4.2.1.zip
|
I tried running CoreNLP with the new files in the zip, but am still getting the same errors... |
Alright, oops. Would you send us a sample text / program which is causing
that crash? I'll try to work it out and post another fix.
|
Just running the pipeline on the given text |
Alright, I see a bug and a potential fix using that example. I posted a new release candidate at the same address. Want to try again? http://downloads.cs.stanford.edu/nlp/software/stanford-corenlp-4.2.1.zip |
Thanks. It seems to work for that example, but here is another example that seems to cause issues: |
Try again? I hopefully fixed that crash as well.
|
I seem to still be getting the same error for the |
No, it's not. Sorry... fix it in a few minutes
|
Alright, I rebuilt it. Try again?
|
Seemed to fix that issue, but I found another (sorry to keep bombarding you like this). They all seem to be under this index out of bounds error. This one is a larger piece of text, so I attached a text file. |
This one is not going to have as quick a turnaround, I'm afraid
|
Found it, I think. Want to try again, same link?
|
PS we hope to make a new release in a week or two, with these changes being part of the updates, so please don't hesitate to send us any more errors you find |
Thanks! This seems to close out the issues I see so far, but I'll keep this open for a bit in case more errors pop up. |
Here's another error I'm getting; something with NullPointerException. |
This is a nice change of pace. I see EXACTLY what the problem is and have
no idea how to fix it, which is somewhat different from the previous
iteration, where at first I had no idea wtf was happening but I could tell
it was an off-by-one error.
…On Mon, Apr 12, 2021 at 8:53 PM Allen Kim ***@***.***> wrote:
Here's another error I'm getting; something with NullPointerException.
passage.txt
<https://github.com/stanfordnlp/CoreNLP/files/6301116/passage.txt>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1147 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2AYWPYU7WD7LAWIUPMW2LTIO52DANCNFSM42NNSSPA>
.
|
Alright, posted the update for that one
…On Mon, Apr 12, 2021 at 9:09 PM John Bauer ***@***.***> wrote:
This is a nice change of pace. I see EXACTLY what the problem is and have
no idea how to fix it, which is somewhat different from the previous
iteration, where at first I had no idea wtf was happening but I could tell
it was an off-by-one error.
On Mon, Apr 12, 2021 at 8:53 PM Allen Kim ***@***.***>
wrote:
> Here's another error I'm getting; something with NullPointerException.
>
> passage.txt
> <https://github.com/stanfordnlp/CoreNLP/files/6301116/passage.txt>
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#1147 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AA2AYWPYU7WD7LAWIUPMW2LTIO52DANCNFSM42NNSSPA>
> .
>
|
Wow, that was fast! It's amazing how quickly you pick up on these things! Much appreciated. Seems good so far. Again, will let you know if anything else is a problem. |
Found one on my own (an bug in one of the previous bugfixes)
http://downloads.cs.stanford.edu/nlp/software/stanford-corenlp-4.2.1.zip
|
Here's another passage with a bug: |
That should also be working now
|
I'm looking to put together a new release of 4.2.1, since there are some
updates to one of its features which can be used from our python package,
Stanza. Since we're already looking to make the quote annotator more
robust, have you noticed any other crashes since the latest update?
Thanks!
|
No crashes so far! Looks like the latest changes are working well! |
Glad to hear it!
|
Here's another snippet of text that raises an error I found. |
Thanks... you can find the fix in the usual place
|
Alright, I put together a more official release including all of the QuoteAnnotator fixes. Please let us know if you find more & we'll start including them for the next version. Otherwise, shall we consider this resolved? |
Yes. Sounds good. I'll let you know if more errors are found, but in the meantime, I appreciate the fixes and we can close this now. |
Hello,
I had a situation with text that had this:
""=
It seems to throw an error when I try running the pipeline with quote annotation on this small fragment. Just wanted to verify that it was an issue.
Thank you.
The text was updated successfully, but these errors were encountered: