Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

StRoot/Stv*: replace sys/types.h with stdint.h #211

Merged
merged 1 commit into from
Nov 24, 2021
Merged

StRoot/Stv*: replace sys/types.h with stdint.h #211

merged 1 commit into from
Nov 24, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 23, 2021 •
edited
Loading

ROOT5 doesn't always work with sys/types.h, types from stdint are the ISO C standard

@veprbl veprbl requested a review from perevbnlgov as a code owner November 23, 2021 06:09
perevbnlgov
perevbnlgov approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@perevbnlgov perevbnlgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that uint was replaced to unsigned int. I do not see the difference.
Especially it is not important, be couse this code is frozen. It is not used now.
But anyway there is no any danger to change it
Victor

@veprbl veprbl mentioned this pull request Nov 24, 2021
Closed
11 tasks
@veprbl veprbl merged commit bb35e49 into star-bnl:main Nov 24, 2021
jml985 pushed a commit that referenced this pull request Dec 7, 2021
@veprbl @jml985
StRoot/Stv*: replace sys/types.h with stdint.h (#211)
7264dc2
marrbnl pushed a commit that referenced this pull request Dec 8, 2021
@veprbl @marrbnl
StRoot/Stv*: replace sys/types.h with stdint.h (#211)
55b754f
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@akioogawa akioogawa akioogawa approved these changes

@perevbnlgov perevbnlgov perevbnlgov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veprbl @perevbnlgov @akioogawa