Adding option to read from MuDst in StFcsRawHitMaker #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro to read from Mudst, re-create StFcsHit in StEvent on momery, and re-run FCS reconstruction makers.
genevb
reviewed
Dec 3, 2021
| @@ -25,7 +25,8 @@ class StFcsRawHitMaker : public StRTSBaseMaker { | |||
|
|
|||
| void setReadMode(int v) {mReadMode=v;} | |||
| void setDebug(int v=1) {SetDebug(v);} //!backward compatubility | |||
|
|
|||
| void setReadMuDst(int v=1) {mReadMuDst=v;} //!reading Mudst/StMuFcsHit into StEvent/StFcsHit | |||
There was a problem hiding this comment.
Not a big deal, but why assign an int to an unsigned int?
There was a problem hiding this comment.
Also, not that you have to make a change, but all makers inherit a mode data member from StMaker. It's pretty harmless to add your own mode data member as you've done, but you can certainly make use of what's already there if you like:
> grep -i mode $STAR/StRoot/StChain/StMaker.h
Int_t m_Mode; //!Integer mode of maker
virtual void SetMode(Int_t mode=0) {m_Mode=mode;} // *MENU*
virtual Int_t GetMode() { return m_Mode;}
And you can get fancy with enum if you want 0 and 1 to represent "normalMode" and "readMode" or something like that. Just throwing it out there.
plexoos
approved these changes
Dec 6, 2021
jdbrice
approved these changes
Dec 6, 2021
jml985
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Adding option to read from Mudst in StFcsRawHitMaker, and example macro to read from Mudst, re-create StFcsHit in StEvent on momery, and re-run FCS reconstruction makers. * unsigned int -> int
marrbnl
pushed a commit
that referenced
this pull request
Dec 8, 2021
* Adding option to read from Mudst in StFcsRawHitMaker, and example macro to read from Mudst, re-create StFcsHit in StEvent on momery, and re-run FCS reconstruction makers. * unsigned int -> int
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding option to read from MuDst in StFcsRawHitMaker, and example macro to read from MuDst, re-create StFcsHits in StEvent on memory, and re-run FCS reconstruction makers.