Fix memory issue in destruction of StBTofGeometry #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@PhilippWeidenkaff reported that MuDst->PicoDst conversion jobs were seg faulting at the end. I investigated in gdb and identified the fault as happening in the destructor of StBTofNode of StBTofGeometry. Looking further with valgrind showed that the issue was that the memory at the location of pView had already been deallocated at the deletion of fView in these two lines:
...under the circumstance where these two had been allocated through these lines in StBTofGeometry.cxx:
The problem is resolved by not deleting pView if pView points to the same memory as fView->GetPosition(). There may be better ways to do this, but this solution appears to me to be working.
-Gene