Add RHICf Run and Event number in StMuRHICfxxx #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexoos
approved these changes
May 29, 2023
jdbrice
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Suggestion: bump the ClassDef version number to ensure backwards compatibility
ClassDef(StMuRHICfRawHit,2)
There was a problem hiding this comment.
Thank you for your suggestion and quick response.
I have applied your comment.
Seunghwan
jdbrice
approved these changes
Jun 1, 2023
|
I will pushed the merge button for next step |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add the RHICfRun and RHICfEvent numbers, I request this 3rd PR.
The modification of StMuRHICfRawHit is to store this data at the MuDst level,
and StMuRHICfUtil is to move the data from the StEvent to the StMuDst level.
A list of PRs for adding run and event numbers before the MuDst production and release STAR libraries:
3) this PR