Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

RFE: Upstream KubeBMC into KubeVirt codebase? #1

Open
JM1 opened this issue Jan 29, 2024 · 19 comments
Open

RFE: Upstream KubeBMC into KubeVirt codebase? #1

JM1 opened this issue Jan 29, 2024 · 19 comments
Assignees
Labels
kind/question Further information is requested

Comments

@JM1
Copy link

JM1 commented Jan 29, 2024

Thanks for KubeBMC, @starbops 🤩 It partially solves a long standing KubeVirt issue ☺️

For increased awareness, usage and easier distribution it would be great if KubeBMC would be incorporated into KubeVirt.

@starbops
Copy link
Owner

Great! I'm delighted that this project addresses some of the issues. I'm willing to assist, so please let me know the next steps or how we should proceed 🙂

@JM1
Copy link
Author

JM1 commented Feb 1, 2024

@0xFelix, one of the KubeVirt hackers, knows better but IIUC a potential way forward could be:

  1. Make KubeBMC an official KubeVirt project, i.e. move it under the KubeVirt umbrella aka https://github.com/kubevirt
  2. coordinate with KubeVirt folks to ensure it meets their coding/quality standards,
  3. maybe create an Kubernetes operator for KubeBMC?!?,
  4. integrate it with the existing KubeVirt ecosystem, e.g. Hyperconverged Cluster Operator.

There are many if's (😅), first and foremost your willingness to make it an official part of KubeVirt. But I am sure that official support for IPMI (and Redfish) in KubeVirt would be super beneficial for the community!

@0xFelix
Copy link

0xFelix commented Feb 2, 2024

@JM1 summarized it pretty well. A first good step would be to introduce KubeBMC on kubevirt-dev and to write a proposal for making it part of the KubeVirt project. An important topic is maintenance of this potential subproject. If it becomes part of KubeVirt, you would also be required to maintain it.

@starbops
Copy link
Owner

starbops commented Feb 4, 2024

Thank you, @JM1 and @0xFelix, for your positive feedback and thoughtful suggestions! I'm absolutely open to contributing KubeBMC to KubeVirt and working towards making it an official part of the project. I appreciate the outlined steps and will start by working on a proposal (is here the right place to send the PR?) and introducing KubeBMC to the kubevirt-dev mailing list.

@0xFelix
Copy link

0xFelix commented Feb 6, 2024

I am pleased to hear that you want to contribute KubeBMC to KubeVirt. I'd start by introducing it on the kubevirt-dev mailing list and asking for feedback on the project. You could outline the steps to make it a part of the KubeVirt project after the introduction. And yes, a proposal in the community repo would be a good next step after that.

@lentzi90
Copy link

With the proposal merged, I guess we should start working on the implementation! 🎉
The first step should be the following, from phase 1 in the proposal:

However, some chores need to be done before transferring. For example, the CRD name should be changed from KubeBMC to a more specific one like VirtualMachineBMC, and the API group of the VirtualMachineBMC CRD needs to be replaced with a suitable name conforming to KubeVirt's convention. Also, the code needs to be protected by robust unit tests and integration test plans.

Any volunteers?

@starbops
Copy link
Owner

@lentzi90 Thanks for bringing this up. I'll create corresponding issues to better track the progress of those tasks. If anyone is interested in any of the items, they can take and start working on it.

@dtantsur
Copy link

A small bit of advice from an Ironic community person: don't bother with IPMI. It's a complicated binary protocol, and you'll get diminishing returns out of supporting it compared to the much simpler (HTTP+JSON) Redfish.

@starbops starbops added the kind/question Further information is requested label Jul 28, 2024
@starbops starbops self-assigned this Jul 28, 2024
@starbops starbops moved this to In progress in KubeVirtBMC project Nov 11, 2024
@starbops starbops moved this from In progress to In review in KubeVirtBMC project Jan 17, 2025
@starbops
Copy link
Owner

We have reached a time point that is good to kick off the transfer of the repository. Any suggestion for how to do it? Thanks! cc @JM1 @0xFelix

@0xFelix
Copy link

0xFelix commented Feb 6, 2025

Hi @starbops, what do you think about making this a GSoC project for KubeVirt?

@starbops
Copy link
Owner

starbops commented Feb 6, 2025

Hi @0xFelix

Thanks for your suggestion about making KubeVirtBMC a GSoC project—I appreciate the idea and am open to exploring it. Could you share more details on how to proceed with that?

Also, I wanted to follow up on the project transfer to the KubeVirt organization. While there’s no strict timeline, I’m eager to move forward when the team is ready. Let me know your thoughts!

Thanks!


We already have some issues labeled with "help wanted", which could spark some ideas for the GSoC project.

@0xFelix
Copy link

0xFelix commented Feb 7, 2025

There is a Google Doc for possible GSoC projects in KubeVirt.

I've added KubeVirtBMC to it. Can you review and possibly add some notes to it?

https://docs.google.com/document/d/13oy-jdAPJjNfl_FpUuOT6O0Sc_q8ruuaZ2e1Q_T90V0/edit?tab=t.0

@aburdenthehand Is there anything left for us to do for now?

@aburdenthehand
Copy link

aburdenthehand commented Feb 7, 2025 via email

@starbops
Copy link
Owner

starbops commented Feb 8, 2025

@0xFelix, I've added some details to the Google Docs. Please let me know if I'm missing anything. Thank you.

@anishbista60
Copy link

anishbista60 commented Feb 13, 2025

@0xFelix Hello ! As mentioned on the google docs for GSOC , I believe you and starbops are working on phase one right ?
I started some work for phase 2. So, just wanted to confirm regarding phase one like who are expected to work on that ?

@0xFelix
Copy link

0xFelix commented Feb 13, 2025

It is part of the GSoC project to complete the missing parts of the first phase. IIUC it should already be largely completed.

@starbops Please correct me.

@starbops
Copy link
Owner

Hi @anishbista60, Thanks for contacting us!

Most of the tasks in phase one have been completed. As Felix said, the expected outcome of the GSoC project is to transfer KubeVirtBMC to the KubeVirt organization and continue working on the remaining phases, including phase two, three, and, optionally, four.

Contributions are always welcome! But I'm unsure whether it conflicts with the GSoC project since it has a clearly defined scope. Might need @0xFelix to help clarify this.

@anishbista60
Copy link

@starbops I mean regarding conflict of interest i am doing it from GSOC perspective . Will show early on approach and work an d apply through proposal at the end. Thanks

@0xFelix
Copy link

0xFelix commented Feb 13, 2025

Just to clarify: Getting familiar with KubeVirtBMC and the GSoC project is fine. But please do not start too much work in advance. Work on the implementation should start as soon as it has been assigned.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/question Further information is requested
Projects
Status: In review
Development

No branches or pull requests

7 participants