Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: correct enum typed data hashing #1281

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: correct enum typed data hashing #1281

merged 1 commit into from
Dec 4, 2024

Conversation

penovicp
Copy link
Collaborator

@penovicp penovicp commented Dec 3, 2024

Motivation and Resolution

Fixes #1278

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@penovicp penovicp mentioned this pull request Dec 3, 2024
Closed
@penovicp penovicp merged commit 6e353d3 into develop Dec 4, 2024
3 checks passed
@penovicp penovicp deleted the fix/enum-typed-data branch December 4, 2024 22:21
penovicp added a commit to penovicp/starknet.js that referenced this pull request Jan 7, 2025
@penovicp
fix: correct enum typed data hashing (starknet-io#1281)
8f8d4d3
penovicp added a commit to penovicp/starknet.js that referenced this pull request Jan 7, 2025
@penovicp
chore: revert typed data enum fixes
4d30c01 
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (starknet-io#1288)"
    ** this reverts commit b903116.
* revert "fix: correct enum typed data hashing (starknet-io#1281)"
    ** this reverts commit 6e353d3.
penovicp added a commit to penovicp/starknet.js that referenced this pull request Jan 7, 2025
@penovicp
chore: revert typed data enum fixes
e4248e4 
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (starknet-io#1288)"
    - this reverts commit b903116
* revert "fix: correct enum typed data hashing (starknet-io#1281)"
    - this reverts commit 6e353d3
penovicp added a commit that referenced this pull request Jan 7, 2025
@penovicp
chore: revert typed data enum fixes
e8db599 
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (#1288)"
    - this reverts commit b903116
* revert "fix: correct enum typed data hashing (#1281)"
    - this reverts commit 6e353d3
penovicp added a commit that referenced this pull request Jan 7, 2025
@penovicp
fix: correct enum typed data hashing (#1281)
4cfe2b2
@penovicp penovicp mentioned this pull request Jan 7, 2025
Open
github-actions bot pushed a commit that referenced this pull request Jan 8, 2025
@semantic-release-bot
chore(release): 6.21.0 [skip ci]
885e747 
# [6.21.0](v6.20.3...v6.21.0) (2025-01-08)

### Bug Fixes

* correct enum typed data hashing ([#1281](#1281)) ([6e353d3](6e353d3))
* rectify snip-12 violation by removing extra `:` in enum encoding ([#1288](#1288)) ([b903116](b903116))
* repair fetch utility for browser environments ([#1293](#1293)) ([2cb1332](2cb1332))

### Features

* enable base fetch override ([#1279](#1279)) ([0fce61e](0fce61e))
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

🎉 This PR is included in version 6.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum encoding is different from the SNIP-12 spec
1 participant
@penovicp