Fix issues with demo setup #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an incompatible breaking change in one of the dependencies of streamlit. Pin it to avoid import/module errors so that the dashboard can start up.
1. pinot image doesn't have `nc` command used for the healthchecks so those always failed. Replace those with using wget to query pinot /health endpoints. 2. depends_on by default does not wait for the dependencies to be healthy but just to be started. Use service_healthy to ensure container is started only after dependencies are ready. 3. The zookeeper healthcheck using `nc` can be insufficient in some cases. In particular, I noticed hangs with pinot waiting for zookeeper while it was up but not ready to accept connections. The ruok/imok command is a better test.
When run with the /deployments/run-java.sh script in the ubi-minimal image, the container exits mysteriously without no visible error. I have been unable to debug the cause of it so far but running the jar directly with java seems to work fine.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nccommand used for the healthchecks so those always failed. Replace those with using wget to query pinot/healthendpoints.depends_onby default does not wait for the dependencies to be healthy but just to be started. Useservice_healthyto ensure container is started only after dependencies are ready.nccan be insufficient in some cases. In particular, I noticed hangs with pinot waiting for zookeeper while it was up but not ready to accept connections. The ruok/imok command is a better test.