skip reencoding compatible video streams #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* skip reencoding compatible video streams * don't attempt copy on transcode with resize
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since MP4 already supports h264 and webm already supports vp8 & vp9 pretty much everywhere, reencoding them can be skipped. Tested on my own files. When seeking, sometimes audio cuts out for a second as -c:v copy only works on full chunks.
I have never used GO before and the change to the go.sum file happened through one of the setup commands. I'll remove it if you don't want that in the tree.