Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build UI artifacts #4824

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

WithoutPants
Copy link
Collaborator

  • Makes the UI routing code consistent when using a custom UI location.
  • Allows the UI location to be provided from the environment ($STASH_UI), or the command line (--ui-location <path> or -u <path>.
  • Adds Makefile target zip-ui to zip the UI files into dist/stash-ui.zip
  • Makes the github build action include stash-ui.zip in the release and build artifacts

The main purpose of this PR is to make it easier to run stash with a custom UI, and to make it easier for users to grab the UI files from PRs and the development build.

@WithoutPants WithoutPants added improvement Something needed tweaking. chore Pull requests for refactoring and admin work labels May 10, 2024
@WithoutPants WithoutPants added this to the Version 0.26.0 milestone May 10, 2024
@WithoutPants WithoutPants merged commit 408d6fc into stashapp:develop May 14, 2024
2 checks passed
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* Flag/env var for stash UI location
* Include UI in build artifacts
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
chore Pull requests for refactoring and admin work improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant