Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Return 401 code for ErrUnauthorized errors #4842

Merged
merged 1 commit into from
May 16, 2024

Conversation

damontecres
Copy link
Contributor

A very tiny PR so that an 401 Unauthorized is returned when the request is unauthorized instead of a 500 Internal Server Error.

This was the behavior before an error lint PR reversed the if condition probably accidentally.

@WithoutPants WithoutPants added the bug Something isn't working label May 16, 2024
@WithoutPants WithoutPants added this to the Version 0.26.0 milestone May 16, 2024
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@WithoutPants WithoutPants merged commit ad844a2 into stashapp:develop May 16, 2024
2 checks passed
@damontecres damontecres deleted the auth-header branch May 17, 2024 02:48
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants