-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add apple encoder and fix extra_hw_frames bug #4986
Merged
WithoutPants
merged 18 commits into
stashapp:develop
from
NodudeWasTaken:hardware-fixes-again
Jun 24, 2024
Merged
Add apple encoder and fix extra_hw_frames bug #4986
WithoutPants
merged 18 commits into
stashapp:develop
from
NodudeWasTaken:hardware-fixes-again
Jun 24, 2024
+227
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On this branch, I receive this error while playing any avi file under cuda:
|
Please check if thats fixed now. |
kermieisinthehouse
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested working but not code reviewed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A discord user complained that the decoder was bugging out, i suspected this was due to extra_hw_frames, jellyfin fixed this by switching from nv12 to yuv420p which disables passthrough.
Jellyfin also adds -threads 1 to cuda to save vram.
Additionally adds the apple encoder for hardware acceleration and brings the requisite fixes.
Like scale_vt lacking dimension adjustments, so we retrofitted the intel hack to calculate the dimensions and used it for apple too.
It also lacks a format switcher, so no 10bit fixes for it.
It also has a higher min resolution than anything we've seen yet, so upped the test resolution.
The only note is that given the apple encoders nature, it really sucks at startup, and given HLS's current tendency to start and stop, it makes the video look like crap.
It technically works, but i dont know that we should keep it.
Last time i fixed a bug that caused using no filter to error out because of the pixel format, so now we can add a format switcher if available.
Closes #4945