[5.x] Allow for large field configs in filters #10822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with filters, where a config field (usually a Select field with lots of options) could cause a request to go over the server's max headers size.
This can be easily resolved by sending the encryped field config in a POST request, rather than a GET request, since POST requests can handle larger payloads.
I've kept the
GETversion of thefield-metaendpoint for now, as it's being used in third-party addons (example).For easier testing, here's a filter with lots of select options: https://gist.github.com/duncanmcclean/171e55a861273d111c6ca037d8650aad