[5.x] Update error indexes when sets/rows are removed #11341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
commented
Jan 10, 2025
| return acc; | ||
| }, {}); | ||
|
|
||
| this.$store.commit(`publish/${this.storeName}/setErrors`, errors); |
There was a problem hiding this comment.
It looks like publish/storeName/setErrors updates the errors in the Vuex state, but it doesn't affect the errors property in the PublishForm component.... not sure if that'll end up being an issue? 🤔
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to fix an issue where errors in Replicator/Grid fields would be displayed on the wrong set/row after a set/row has been removed.
This PR attempts to fix it by updating the indexes in error keys whenever sets/rows are removed.
It's a bit gnarly... I'm not entirely convinced this is the right solution, so let me know if you can think of a better one.
Fixes #10704.
Fixes #11286.