[5.x] Separate globals config and content #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's still two failing tests locally, I'll get these fixed up tomorrow.
duncanmcclean
force-pushed
the
separate-globals
branch
from
cbd6ae8 to
8f7ea26
Compare
|
While the tests are failing on GitHub Actions, they all pass locally when using the |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the required changes to accommodate the changes in statamic/cms#11585, including:
sitesoption on global setssitesarray, rather than checking the existence of global variables in sites.origincolumn on theglobal_set_variablestable, as the origin now comes from thesitesarray.UpdateGlobalVariables), mirroring the update script from my Core PR, but just touching the database rather than YAML files.