The task to add the Brave repository is broken. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got rid of the `shell` task and replaced it with a simple `copy` task instead. Shell task used `sudo` command causing the installation to hang for a user without passwordless sudo.
|
@cdemeijer can you give me some more information on what is broken about the repo? |
|
@cdemeijer I will close this PR since I could not reproduce the problem and didn't get an answer from you. I will be glad to reopen if you provide enough details. |
|
As stated, the task did not work for me because it required passwordless sudo (or running everything as root). |
|
Sorry I see you are right. Also LGTM. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got rid of the
shelltask and replaced it with a simplecopytask instead. (Template seems overkill here).Shell task used
sudocommand causing the installation to hang for a user that does not have passwordless sudo.