Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update ci.yml and be more explicit in .nimble #174

Merged
merged 3 commits into from
Jun 26, 2024
Merged

update ci.yml and be more explicit in .nimble #174

merged 3 commits into from
Jun 26, 2024

Conversation

narimiran
Copy link
Contributor

No description provided.

@tersec
Copy link
Contributor

tersec commented Jun 26, 2024

Since it now depends on the nim-results package directly,

requires "nim >= 1.6.0",
"nimcrypto",
"stew",
"taskpools >= 0.0.5"

should note this by including "results",

@narimiran
Copy link
Contributor Author

narimiran commented Jun 26, 2024

Since it now depends on the nim-results package directly,

requires "nim >= 1.6.0",
"nimcrypto",
"stew",
"taskpools >= 0.0.5"

should note this by including "results",

I think your code points to an unrelated commit, because in this PR I've added results to .nimble:

https://github.com/status-im/nim-blscurve/pull/174/files#diff-9f1abdcf6f2e6d45a1f607604071183240d9a5b59762b84a39caf9ce5efdc5f1R16

requires "nim >= 1.6.0",
"nimcrypto",
"stew",
"results",
"taskpools >= 0.0.5"

@tersec
Copy link
Contributor

tersec commented Jun 26, 2024

Since it now depends on the nim-results package directly,

requires "nim >= 1.6.0",
"nimcrypto",
"stew",
"taskpools >= 0.0.5"

should note this by including "results",

I think your code points to an unrelated commit, because in this PR I've added results to .nimble:

https://github.com/status-im/nim-blscurve/pull/174/files#diff-9f1abdcf6f2e6d45a1f607604071183240d9a5b59762b84a39caf9ce5efdc5f1R16

requires "nim >= 1.6.0",
"nimcrypto",
"stew",
"results",
"taskpools >= 0.0.5"

Oops, yeah, you're right.

@tersec tersec merged commit 1d0d886 into master Jun 26, 2024
15 checks passed
@tersec tersec deleted the update-ci branch June 26, 2024 05:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants