-
Notifications
You must be signed in to change notification settings - Fork 270
Revisiting log levels #1788
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Revisiting log levels #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
tersec
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
tersec
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
tersec
reviewed
Oct 1, 2020
arnetheduck
reviewed
Oct 1, 2020
arnetheduck
approved these changes
Oct 1, 2020
let's also add a |
tersec
approved these changes
Oct 1, 2020
This was referenced Oct 1, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1779 #1785
Description/Philosophy
Note: it is important not to fill disk with logs, this prevent analyzing them visually.
Logs done at high frequency should be summarized even at trace level to avoid drowning other subsystem
For example they can use an uint8 counter with
For the keep alive / control message that were done by Gossipsub: https://github.com/status-im/nim-libp2p/pull/381/files
TODO
The current color of the notice level is confusing, it seems like an issue that needs to be addressed and seems to sit in-between warning and error.