fix(images): Display image placeholder when image from album not loaded #10203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borismelnik
requested review from
glitchminer,
a team,
iurimatias,
mprakhov and
jrainville
and removed request for
a team
Jenkins BuildsClick to see older builds (6)
|
jrainville
approved these changes
Apr 5, 2023
| @@ -224,6 +225,8 @@ proc toMessageDto*(jsonObj: JsonNode): MessageDto = | |||
| discard jsonObj.getProp("contactRequestState", result.contactRequestState) | |||
| discard jsonObj.getProp("image", result.image) | |||
| discard jsonObj.getProp("albumId", result.albumId) | |||
| echo "LALALA", jsonObj | |||
borismelnik
force-pushed
the
fix/issue-9990-album-count
branch
from
5eeaae6 to
b2b7936
Compare
borismelnik
force-pushed
the
fix/issue-9990-album-count
branch
from
b2b7936 to
db10208
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9990
What does the PR do
Display image placeholder.
Unfortunately, old versions where album was received can't display images anymore. But I will try to add some migration to status which add
albumCountfor old albums.Affected areas
Message view
StatusQ checklist
Screenshot of functionality (including design for comparison)