Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ActivityCenter): Workaround for nil message #10460

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

MishkaRogachev
Copy link
Contributor

Close #10455

What does the PR do

AC notification can have nil message, but with recent changes this caused segfault

Affected areas

ActivityCenter

Screenshot of functionality (including design for comparison)

Screenshot 2023-04-27 at 16 25 39

@status-im-auto
Copy link
Member

status-im-auto commented Apr 27, 2023

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 105df1d #1 2023-04-27 12:35:40 ~5 min tests/imports 📄log
✔️ 105df1d #1 2023-04-27 12:36:31 ~6 min tests/nim 📄log
✖️ 105df1d #1 2023-04-27 12:41:51 ~11 min tests/e2e 📄log
✔️ 105df1d #1 2023-04-27 12:43:16 ~12 min macos/x86_64 🍎dmg
✔️ 105df1d #1 2023-04-27 12:47:07 ~16 min linux/x86_64 📦tgz
✖️ 105df1d #2 2023-04-27 12:55:20 ~7 min tests/e2e 📄log
✔️ 105df1d #1 2023-04-27 13:02:20 ~31 min windows/x86_64 💿exe
✔️ 105df1d #1 2023-04-27 13:14:32 ~44 min macos/aarch64 🍎dmg
✖️ 105df1d #3 2023-04-27 13:42:50 ~1 min tests/e2e 📄log
✔️ 7d2de3b #2 2023-04-27 14:36:03 ~7 min macos/aarch64 🍎dmg
✔️ 7d2de3b #2 2023-04-27 14:37:09 ~8 min tests/imports 📄log
✔️ 7d2de3b #2 2023-04-27 14:39:24 ~11 min tests/nim 📄log
✔️ 7d2de3b #2 2023-04-27 14:39:52 ~11 min macos/x86_64 🍎dmg
✔️ 7d2de3b #2 2023-04-27 14:44:27 ~16 min linux/x86_64 📦tgz
✔️ 7d2de3b #4 2023-04-27 14:50:09 ~22 min tests/e2e 📄log
✔️ 7d2de3b #2 2023-04-27 14:54:01 ~25 min windows/x86_64 💿exe

Co-authored-by: saledjenic <86303051+saledjenic@users.noreply.github.com>
@MishkaRogachev MishkaRogachev merged commit 591d466 into master Apr 27, 2023
@MishkaRogachev MishkaRogachev deleted the hotfix/nil-message-for-ac-notification branch April 27, 2023 15:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault on receiving community request notification
4 participants