fix(Onboarding): Image is visible after first onboard. Other minor fixes #10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
commented
Apr 30, 2023
| @@ -435,7 +435,9 @@ QtObject { | |||
|
|
|||
| function isEnsVerified(publicKey) { | |||
| if (publicKey === "" || !isChatKey(publicKey) ) | |||
| return | |||
| return false | |||
| if (!mainModuleInst) | |||
There was a problem hiding this comment.
This is the fix of identicon ring
There was a problem hiding this comment.
this may be done in one line return !mainModuleInst && mainModuleInst.isEnsVerified(publicKey) :)
igor-sirotin
commented
Apr 30, 2023
| @@ -407,7 +407,8 @@ method onNodeLogin*[T](self: Module[T], error: string) = | |||
| self.logoutAndDisplayError(err, StartupErrorType.UnknownType) | |||
| return | |||
| if currStateObj.flowType() != FlowType.AppLogin: | |||
| discard self.controller.storeIdentityImage() | |||
| let images = self.controller.storeIdentityImage() | |||
| self.accountsService.updateLoggedInAccount(self.getDisplayName, images) | |||
There was a problem hiding this comment.
This is the fix of lost profile image
Jenkins Builds
|
jrainville
approved these changes
May 1, 2023
borismelnik
reviewed
May 2, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10099
What does the PR do
Affected areas
Onboarding
Screenshot of functionality (including design for comparison)
Screen.Recording.2023-04-30.at.14.58.24.mov