fix: Fixed community channel emoji not updated #10534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-sirotin
requested review from
jrainville,
a team and
Cuteivist
and removed request for
a team
caybro
approved these changes
May 3, 2023
Jenkins Builds
|
jrainville
approved these changes
May 3, 2023
| @@ -665,8 +665,11 @@ QtObject: | |||
| return toSeq(self.getFilteredCuratedCommunities.values) | |||
|
|
|||
| proc getCommunityById*(self: Service, communityId: string): CommunityDto = | |||
| if(not self.communities.hasKey(communityId)): | |||
| error "error: requested community doesn't exists", communityId | |||
| if communityId == "": | |||
There was a problem hiding this comment.
Maybe we have a deeper issue here? Why are we calling getCommunityById with an empty string? It's probably nothing, but it would be nice to know.
Not that it needs to be fixed in this PR, it's just that this change will hide the symptom so we'll forget haha
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10190
What does the PR do
communityId