chore(@desktop/wallet): Simplify the wallet networks service #13995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
force-pushed
the
chore/#12717
branch
from
5963be3 to
b97e016
Compare
Jenkins BuildsClick to see older builds (57)
|
Khushboo-dev-cpp
force-pushed
the
chore/#12717
branch
5 times, most recently
from
ff17f9a to
4e33673
Compare
Khushboo-dev-cpp
force-pushed
the
chore/#12717
branch
5 times, most recently
from
3f3bb33 to
bde077c
Compare
✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-13995#12 🔹 ~6 min 45 sec 🔹 bde077c 🔹 📦 tests/nim package |
Khushboo-dev-cpp
requested review from
saledjenic,
stefandunca,
IvanBelyakoff,
alaibe,
dlipicar and
Cuteivist
and removed request for
saledjenic and
stefandunca
stefandunca
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Great simplification of networks handling. The common source of truth will hopefully help avoid network related issues in the future. I still don't like how test mode is everywhere instead of just having available networks, maybe in a future we can improve on this also.
dlipicar
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
nice!
There's some cleanup we can do on the collectibles side by left-joining network info instead of inserting it into each entry (https://github.com/status-im/status-desktop/blob/master/src/app/modules/shared_models/collectibles_entry.nim#L16)
saledjenic
approved these changes
Mar 28, 2024
Yes we could create a follow up task for that so that its not lost. |
Khushboo-dev-cpp
force-pushed
the
chore/#12717
branch
from
bde077c to
fd78a4d
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12717
What does the PR do
Simplifying the networks service and creating only 2 base types -
Moving all the layer1, layer2 , enabled submodels to qml by using SortFilterProxyModels
I will be moving the networks submodule in profile in the next PR as this PR is already too bug.
Affected areas
Networks in UI (all app)
StatusQ checklist
Screenshot of functionality (including design for comparison)