Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: bump status-go #14064

Merged

Conversation

MishkaRogachev
Copy link
Contributor

Close #14047
Waits status-im/status-go#4956

Fix crash if it's not possible to fetch community member as a contact

Screen.Recording.2024-03-20.at.12.15.10.mov

@MishkaRogachev
Copy link
Contributor Author

@glitchminer can you please try this brach, i can't reproduce this crash locally

@MishkaRogachev MishkaRogachev marked this pull request as ready for review March 20, 2024 13:53
@status-im-auto
Copy link
Member

status-im-auto commented Mar 20, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0b822e2 #1 2024-03-20 13:58:50 ~6 min tests/nim 📄log
✔️ 0b822e2 #1 2024-03-20 14:02:22 ~10 min macos/aarch64 🍎dmg
0b822e2 #1 2024-03-20 14:03:49 ~11 min tests/ui 📄log
✔️ 0b822e2 #1 2024-03-20 14:04:32 ~12 min macos/x86_64 🍎dmg
✔️ 0b822e2 #1 2024-03-20 14:09:50 ~18 min linux/x86_64 📦tgz
✔️ 0b822e2 #1 2024-03-20 14:16:26 ~24 min windows/x86_64 💿exe
✔️ 0b822e2 #2 2024-03-21 08:30:35 ~10 min tests/ui 📄log
5670b1d #2 2024-03-21 19:52:22 ~5 min macos/aarch64 📄log
✔️ 5670b1d #2 2024-03-21 19:53:13 ~6 min tests/nim 📄log
✔️ 5670b1d #2 2024-03-21 19:54:56 ~8 min macos/x86_64 🍎dmg
✔️ 5670b1d #3 2024-03-21 19:57:54 ~11 min tests/ui 📄log
✔️ 5670b1d #2 2024-03-21 20:01:53 ~15 min linux/x86_64 📦tgz
✔️ 5670b1d #3 2024-03-21 20:02:25 ~6 min macos/aarch64 🍎dmg
✔️ 5670b1d #2 2024-03-21 20:10:10 ~23 min windows/x86_64 💿exe

@anastasiyaig
Copy link
Contributor

we need to resolve conflicts here and cherry pick to release branch @jrainville

@jrainville
Copy link
Member

@MishkaRogachev can you do it please.

I think Mishka also had issues reproducing. Can @glitchminer test it to see if it worked for him

@MishkaRogachev
Copy link
Contributor Author

@MishkaRogachev can you do it please.

I think Mishka also had issues reproducing. Can @glitchminer test it to see if it worked for him

sure, i'll do it after testing if it works

@glitchminer
Copy link
Contributor

Tested OK, bug is no longer reproducible.

@MishkaRogachev MishkaRogachev force-pushed the fix/issue-14047-crash-on-editing-display-name-field branch from 0b822e2 to 5670b1d Compare March 21, 2024 19:46
@MishkaRogachev MishkaRogachev merged commit b839502 into master Mar 21, 2024
8 checks passed
@MishkaRogachev MishkaRogachev deleted the fix/issue-14047-crash-on-editing-display-name-field branch March 21, 2024 20:31
alexjba pushed a commit that referenced this pull request Apr 3, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on editing display name field
7 participants