Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: can't use the Tab button in the Mint Token form #14138

Merged

Conversation

caybro
Copy link
Member

@caybro caybro commented Mar 25, 2024

What does the PR do

  • manually setup the TAB focus chain; in the future, this should be done properly on all new components using FocusScopes and similar

Fixes #13891

Affected areas

EditCommunityTokenView

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it
Zaznam.obrazovky.z.2024-03-25.11-08-18.webm

- manually setup the TAB focus chain; in the future, this should be done
properly on all new components using FocusScopes and similar

Fixes #13891
@caybro caybro linked an issue Mar 25, 2024 that may be closed by this pull request
@status-im-auto
Copy link
Member

status-im-auto commented Mar 25, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ fed9f6d #1 2024-03-25 10:15:40 ~6 min tests/nim 📄log
✔️ fed9f6d #1 2024-03-25 10:18:19 ~8 min macos/aarch64 🍎dmg
✔️ fed9f6d #1 2024-03-25 10:19:59 ~10 min macos/x86_64 🍎dmg
✔️ fed9f6d #1 2024-03-25 10:21:17 ~11 min tests/ui 📄log
✔️ fed9f6d #1 2024-03-25 10:26:09 ~16 min linux/x86_64 📦tgz
✔️ fed9f6d #1 2024-03-25 10:37:09 ~27 min windows/x86_64 💿exe

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@caybro caybro merged commit ec4e2f3 into master Mar 25, 2024
8 checks passed
@caybro caybro deleted the 13891-you-cant-use-the-tab-button-in-the-mint-token-form branch March 25, 2024 13:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

You can't use the Tab button in the Mint Token form
4 participants