fix(communities): keycard authentication marked automatically as authenticated #14182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
caybro
approved these changes
Mar 27, 2024
noeliaSD
approved these changes
Mar 27, 2024
| @@ -140,7 +140,7 @@ method delete*(self: Module) = | |||
| self.controller.delete | |||
| self.communityTokensModule.delete | |||
|
|
|||
| proc clean(self: Module) = | |||
| method cleanJoinEditCommunityData*(self: Module) = | |||
There was a problem hiding this comment.
Which kind of details are cleared here? Just for me to have more context :)
There was a problem hiding this comment.
Details set to self.joiningCommunityDetails, look at the JoiningCommunityDetails object.
21 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for this issue was in the line
726inmodule.nim, but I also made a change to make sure that all sensitive data kept in the memory while the popup is active gets cleared on the popup close.Closes #14174