feat: Add missing eligible to join tag in CommunityMembershipSetupDialog #14187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
commented
Mar 27, 2024
Jenkins BuildsClick to see older builds (30)
|
caybro
force-pushed
the
14100-add-missing-eligible-to-join-tag-in-request-to-join-community-dialog
branch
2 times, most recently
from
9a9b444 to
a2329a4
Compare
caybro
force-pushed
the
14100-add-missing-eligible-to-join-tag-in-request-to-join-community-dialog
branch
from
a2329a4 to
c04fdd6
Compare
jrainville
approved these changes
Mar 28, 2024
seems like this check had gone missing
caybro
force-pushed
the
14100-add-missing-eligible-to-join-tag-in-request-to-join-community-dialog
branch
2 times, most recently
from
b0cb1c0 to
c5b3a23
Compare
- implement the eligibility check in C++, returning the highest possible role the user would be allowed to join under - enable/disable the "Share" button based on the above permissions check - remove all the locally placed components, access teh popup only via Global/Popups - calculate the `accessType` internally based on the permissions present - update the eligibility as the async check for permissions is finished - fix the permissions panel background color - partially revert the share/finish/cancel buttons behavior; it must be one button due to StatusStackModal limitations - fix some other minor UI issues or differences to current Figma designs - adjust SB, add the possibility to play around with different permission models Fixes #14100
caybro
force-pushed
the
14100-add-missing-eligible-to-join-tag-in-request-to-join-community-dialog
branch
from
c5b3a23 to
1568caf
Compare
caybro
deleted the
14100-add-missing-eligible-to-join-tag-in-request-to-join-community-dialog
branch
This was referenced Apr 3, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
accessTypeinternally based on the permissions presentFixes #14100
Fixes #14171
Fixes #14088
Affected areas
CommunityMembershipSetupDialog, SharedAddressesPanel, SharedAddressesPermissionsPanel
Screenshot of functionality (including design for comparison)