Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(CancelCommunityMembership): Added popup instead of directly cancelling request #14201

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

noeliaSD
Copy link
Contributor

Closes #14097

What does the PR do

  • Added dialog instead of calling directly to the cancel method.
  • Updated Cancel button format according to figma in CommunityMembershipSetupDialog.

Affected areas

Join Community flow

Screenshot of functionality

Screen.Recording.2024-03-27.at.18.38.32.mov

…lling request

- Added dialog instead of calling directly to the cancel method.
- Updated `Cancel` button format according to figma in `CommunityMembershipSetupDialog`.

Closes #14097
@noeliaSD noeliaSD added the bug Something isn't working label Mar 27, 2024
@noeliaSD noeliaSD self-assigned this Mar 27, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 27, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ eaa4055 #1 2024-03-27 17:50:29 ~6 min tests/nim 📄log
✔️ eaa4055 #1 2024-03-27 17:53:16 ~9 min macos/aarch64 🍎dmg
✔️ eaa4055 #1 2024-03-27 17:54:26 ~10 min tests/ui 📄log
✔️ eaa4055 #1 2024-03-27 17:56:43 ~13 min macos/x86_64 🍎dmg
✔️ eaa4055 #1 2024-03-27 18:01:14 ~17 min linux/x86_64 📦tgz
✔️ eaa4055 #1 2024-03-27 18:07:46 ~24 min windows/x86_64 💿exe

@status-im-auto
Copy link
Member

✔️ status-desktop/prs/linux/x86_64/tests-nim/PR-14201#1 🔹 ~6 min 52 sec 🔹 eaa4055 🔹 📦 tests/nim package

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

@noeliaSD noeliaSD merged commit 67f0f38 into master Mar 28, 2024
8 checks passed
@noeliaSD noeliaSD deleted the fix/issue-14097 branch March 28, 2024 06:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
4 participants