Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(wallet): Handled failed to load collectible image state #14229

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

Cuteivist
Copy link
Contributor

Task #13807

What does the PR do

Showing grey rectangle when image cannot be loaded or data cannot be fetched

Affected areas

Wallet / collectible details view

Screenshot of functionality (including design for comparison)

image

@status-im-auto
Copy link
Member

status-im-auto commented Mar 29, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7a57d1f #1 2024-03-29 09:59:25 ~6 min tests/nim 📄log
✔️ 7a57d1f #1 2024-03-29 10:00:17 ~7 min macos/aarch64 🍎dmg
✔️ 7a57d1f #1 2024-03-29 10:03:22 ~10 min macos/x86_64 🍎dmg
✔️ 7a57d1f #1 2024-03-29 10:05:37 ~12 min tests/ui 📄log
✔️ 7a57d1f #1 2024-03-29 10:11:02 ~17 min linux/x86_64 📦tgz
✔️ 7a57d1f #1 2024-03-29 10:20:01 ~26 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@stefandunca stefandunca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Cuteivist Cuteivist merged commit 6dec612 into master Mar 30, 2024
8 checks passed
@Cuteivist Cuteivist deleted the feat/13807-collectible-details-empty-image branch March 30, 2024 05:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants