feat(SharedAddressesAccountSelector): update wallet account sorting #14240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (18)
|
caybro
commented
Apr 1, 2024
| sourceModel: root.walletAccountsModel | ||
| sorters: [ |
There was a problem hiding this comment.
Removing the old sorting code (walletType/position/name) but keeping the SFPM; some other JS code here relies on its .count/.get methods
micieslak
force-pushed
the
feat/issue-14102
branch
from
9860aa1 to
bf1fc59
Compare
caybro
force-pushed
the
14101-fix-sort-by-tokens-count
branch
from
69705b0 to
713ef3b
Compare
caybro
force-pushed
the
14101-fix-sort-by-tokens-count
branch
from
713ef3b to
f070df5
Compare
micieslak
reviewed
Apr 2, 2024
ui/app/AppLayouts/Communities/panels/SharedAddressesAccountSelector.qml
Outdated
Show resolved
Hide resolved
caybro
force-pushed
the
14101-fix-sort-by-tokens-count
branch
from
f070df5 to
d2afe5f
Compare
- speed up the construction of the permissions overview panels
micieslak
approved these changes
Apr 2, 2024
| @@ -226,6 +257,18 @@ Control { | |||
| getCurrencyAmount: function (balance, symbol) { | |||
| return root.getCurrencyAmount(balance, symbol) | |||
| } | |||
|
|
|||
| Component.onCompleted: { | |||
| const tmpTokenCountMap = new Map() | |||
There was a problem hiding this comment.
This make the flow really intertwined but I understand that's workaround for now... Added note to #14140 in order to refactor in the future.
There was a problem hiding this comment.
Yeah, it's not pretty but I couldn't see any other way without completely factoring out the (sub)models construction
- implement sorting of the wallet accounts by the number of tokens (aka tags) and then by alphabet - due to the delegate complexity here and usage of nested models, keep track of the tags count separately and outside of the model - this will be improved later on as part of the complete sort/order design described in #14192 Fixes #14101
caybro
force-pushed
the
14101-fix-sort-by-tokens-count
branch
from
d2afe5f to
f3bcae3
Compare
21 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #14101
Affected areas
SharedAddressesAccountSelector, SharedAddressesPanel
Screenshot of functionality (including design for comparison)