fix(Profile): Fix crashing when showcase collectible having disabled chainIds #14252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
approved these changes
Apr 2, 2024
Jenkins Builds
|
dlipicar
approved these changes
Apr 2, 2024
MishkaRogachev
deleted the
fix/issue-14243-profile-showcase-app-is-crashing-when-viewing-profile-showcase-while-testnet-is-active
branch
endulab
reviewed
Apr 3, 2024
| @@ -87,3 +87,10 @@ proc isPathOutOfTheDefaultStatusDerivationTree*(path: string): bool = | |||
|
|
|||
| proc contractUniqueKey*(chainId: int, contractAddress: string): string = | |||
| return $chainId & "_" & contractAddress | |||
|
|
|||
| proc intersectSeqs*[T](seq1, seq2: seq[T]): seq[T] = | |||
There was a problem hiding this comment.
@MishkaRogachev you provided a new compilation warning in this function.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #14243
What does the PR do
Fix crash when a profile collectible had a chainId from disabled network e.g main net chain id when test net is enabled
Affected areas
Profile
Screenshot of functionality (including design for comparison)