Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop peers when rate limit is exceeded #1732

Merged
merged 4 commits into from
Dec 16, 2019
Merged

Conversation

adambabik
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Dec 13, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@adambabik adambabik force-pushed the drop-peers-rate-limit branch from 69d6dea to 284d42c Compare December 13, 2019 14:08
@adambabik adambabik requested a review from cammellos December 13, 2019 15:43
@status-im-auto
Copy link
Member

status-im-auto commented Dec 14, 2019

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 284d42c #1 2019-12-14 11:55:46 ~3 min linux 📦zip
284d42c #1 2019-12-14 12:04:31 ~12 min ios 📄log
284d42c #1 2019-12-14 12:10:04 ~17 min android 📄log
284d42c #2 2019-12-15 22:01:38 ~2 min ios 📄log
284d42c #2 2019-12-15 22:02:13 ~2 min android 📄log
c9f9445 #3 2019-12-15 22:03:43 ~25 sec ios 📄log
✔️ c9f9445 #2 2019-12-15 22:04:13 ~54 sec linux 📦zip
c9f9445 #3 2019-12-15 22:05:05 ~1 min android 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 48671b6 #3 2019-12-15 22:06:07 ~35 sec linux 📦zip
✔️ 48671b6 #4 2019-12-15 22:09:25 ~3 min ios 📦zip
✔️ 48671b6 #4 2019-12-15 22:13:13 ~7 min android 📦aar
✔️ 7c6f153 #4 2019-12-16 14:46:55 ~54 sec linux 📦zip
✔️ 7c6f153 #5 2019-12-16 14:49:25 ~3 min ios 📦zip
✔️ 7c6f153 #5 2019-12-16 14:52:53 ~6 min android 📦aar

@oskarth
Copy link
Contributor

oskarth commented Dec 16, 2019

@adambabik do we have any data on how rate limiting limits behave in practice?

@adambabik
Copy link
Contributor Author

@oskarth we have some numbers from the eth.test. Not sure about what you ask specifically. Generally, I imagine that at some point we will gradually introduce rate limiting for nodes and mobile clients to find the optimal configuration. This PR adds a capability, the configuration is dynamic per node.

@adambabik adambabik merged commit 4f45bce into develop Dec 16, 2019
@adambabik adambabik deleted the drop-peers-rate-limit branch December 16, 2019 19:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants