Remove SelectKeyPair and SelectedKeyPairID methods from Whisper #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (15)
|
|
@adambabik looks like one if the |
|
@adambabik remember to also remove |
pedropombeiro
approved these changes
Dec 30, 2019
…rID methods from Whisper
pedropombeiro
force-pushed
the
remove-selected-key-whisper
branch
from
ea5e224 to
7e3a385
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a notion of an active key pair from Whisper. The management of the active key pair should be put on status-go rather than Whisper.
This change also removes deduplication because it is currently not used.
Closes #1747