Abstract the keystore #1752
Merged
Abstract the keystore #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (78)
|
pedropombeiro
force-pushed
the
abstract-keystore
branch
14 times, most recently
from
6a92a2d to
f270139
Compare
adambabik
reviewed
Dec 20, 2019
pedropombeiro
force-pushed
the
abstract-keystore
branch
from
f270139 to
894d51a
Compare
|
Thanks for the review Adam! I've addressed the feedback. |
pedropombeiro
force-pushed
the
abstract-keystore
branch
5 times, most recently
from
10ecf5b to
20ea602
Compare
pedropombeiro
force-pushed
the
abstract-keystore
branch
2 times, most recently
from
8273b70 to
deb876e
Compare
pedropombeiro
force-pushed
the
abstract-keystore
branch
from
deb876e to
cd175da
Compare
adambabik
reviewed
Jan 2, 2020
| @@ -176,6 +176,10 @@ prepare-release: clean-release | |||
| clean-release: | |||
| rm -rf $(RELEASE_DIR) | |||
|
|
|||
| gofmt: | |||
There was a problem hiding this comment.
Up to you, but there are many unrelated files changed because of this.
adambabik
approved these changes
Jan 2, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts the Keystore so that it can rely on the geth implementation or the Nimbus implementation (upcoming). It introduces two new types:
types.Keyandtypes.Accountthat we should use instead of the Geth versions. It also pulls in theDecryptKeyfunction from geth.