feat: l1 gas price estimation when placing l2 transaction #4923

saledjenic · 2024-03-14T13:38:54Z

No description provided.

status-im-auto · 2024-03-14T13:42:54Z

Jenkins Builds

Click to see older builds (24)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d4dc656`	#1	2024-03-14 13:42:53	~3 min	`linux`	📦`zip`
✔️	`d4dc656`	#1	2024-03-14 13:44:07	~4 min	`ios`	📦`zip`
✔️	`d4dc656`	#1	2024-03-14 13:44:24	~5 min	`android`	📦`aar`

✔️	`4067f22`	#2	2024-03-18 08:34:04	~2 min	`ios`	📦`zip`
✔️	`4067f22`	#2	2024-03-18 08:34:16	~2 min	`linux`	📦`zip`
✔️	`4067f22`	#2	2024-03-18 08:36:37	~5 min	`android`	📦`aar`
✔️	`4067f22`	#2	2024-03-18 09:10:10	~38 min	`tests`	📄`log`

✔️	`d9bd863`	#3	2024-03-25 12:45:20	~3 min	`linux`	📦`zip`
✔️	`d9bd863`	#3	2024-03-25 12:47:35	~5 min	`android`	📦`aar`

✔️	`a2383ca`	#4	2024-03-25 16:01:14	~2 min	`linux`	📦`zip`
✔️	`a2383ca`	#4	2024-03-25 16:02:49	~4 min	`android`	📦`aar`
✔️	`a2383ca`	#4	2024-03-25 16:06:14	~7 min	`ios`	📦`zip`

✔️	`48d0dd3`	#5	2024-03-26 10:50:33	~2 min	`android`	📦`aar`
✔️	`48d0dd3`	#5	2024-03-26 10:51:51	~3 min	`linux`	📦`zip`
✔️	`48d0dd3`	#5	2024-03-26 10:51:57	~3 min	`ios`	📦`zip`
✔️	`48d0dd3`	#5	2024-03-26 11:27:39	~39 min	`tests`	📄`log`

✔️	`6e30e1c`	#6	2024-03-26 11:56:43	~2 min	`linux`	📦`zip`
✔️	`6e30e1c`	#6	2024-03-26 11:57:10	~2 min	`android`	📦`aar`
✔️	`6e30e1c`	#6	2024-03-26 11:58:24	~3 min	`ios`	📦`zip`
✔️	`6e30e1c`	#6	2024-03-26 12:34:35	~39 min	`tests`	📄`log`

✔️	`46955b1`	#7	2024-03-26 12:56:18	~1 min	`linux`	📦`zip`
✔️	`46955b1`	#7	2024-03-26 12:56:40	~2 min	`android`	📦`aar`
✔️	`46955b1`	#7	2024-03-26 12:57:50	~3 min	`ios`	📦`zip`
✔️	`46955b1`	#8	2024-03-26 14:29:39	~39 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`daed981`	#8	2024-03-26 14:11:11	~15 sec	`linux`	📄`log`
❌	`daed981`	#8	2024-03-26 14:11:17	~20 sec	`ios`	📄`log`
❌	`daed981`	#8	2024-03-26 14:11:20	~21 sec	`android`	📄`log`

✔️	`1c59e85`	#9	2024-03-26 14:17:16	~1 min	`linux`	📦`zip`
✔️	`1c59e85`	#9	2024-03-26 14:17:41	~2 min	`android`	📦`aar`
✔️	`1c59e85`	#9	2024-03-26 14:18:47	~3 min	`ios`	📦`zip`
✔️	`1c59e85`	#9	2024-03-26 15:09:17	~39 min	`tests`	📄`log`

alaibe · 2024-03-26T08:46:11Z

services/wallet/router.go

@@ -547,6 +549,48 @@ func (r *Router) getERC1155Balance(ctx context.Context, network *params.Network,
 	return balances[0].Int, nil
 }

+func (r *Router) getL1Fee(ctx context.Context, network *params.Network, fromAddress common.Address, toAddress common.Address, amountIn *big.Int) (uint64, error) {


I tested sending erc20 and sending eth from metamask and there is differences in l1 fees.

I beleve this logic is only valid for the case of sending eth, there should be logic for all types of tx:
Bridge / buy ENS, send ERC20, sendERC71.

This logic should be encapsulated by bridge

services/wallet/router.go

alaibe · 2024-03-26T08:48:08Z

services/wallet/router.go

@@ -737,6 +792,7 @@ func (r *Router) suggestedRoutes(
 						AmountIn:                (*hexutil.Big)(zero),
 						AmountOut:               (*hexutil.Big)(zero),
 						GasAmount:               gasLimit,
+						L1GasAmount:             l1Fee,


as said above, this should directly be attached to the gasfees

alaibe · 2024-03-26T08:49:42Z

services/wallet/router.go

-					// Removed the required fees from maxAMount in case of native token tx
-					if token.IsNative() {
-						maxAmountIn = (*hexutil.Big)(new(big.Int).Sub(maxAmountIn.ToInt(), requiredNativeBalance))
+					approvalRequired, approvalAmountRequired, approvalGasLimit, approvalContractAddress, err := r.requireApproval(ctx, sendType, bridge, addrFrom, network, token, amountIn)


require approval should also have a l1 fees dedicated value

alaibe

General question: what happens when the chain is not optimism, can we have a guard and stop early?

alaibe · 2024-03-26T12:11:33Z

services/wallet/router.go

 	}

-	return true, amountIn, estimate, bridgeAddress, nil
+	l1Fee, _ := r.getL1Fee(ctx, network, token.Address, account, amountIn)


Require approval is not a eth transaction, here we are calling get L1 fee assuming it is, isn't possible to call getL1Fees witht the data above?

@alaibe if we call it on other than the optimism chain we will get an error like L1 fee not supported on this chain and the value will be 0, so we continue the block execution, doesn't need to skip the loop.

Thanks for answering and good for me, but this comment is about this specific call which need to buil getL1Fee for require approval not for eth tx

alaibe · 2024-03-26T12:13:40Z

services/wallet/bridge/erc1155_transfer.go

+		},
+	}
+
+	tx, err := s.BuildTransaction(sendArgs)


nit: all the belows seems repeated accross all bridge, maybe move this into fees.go?

updated, thanks

alaibe · 2024-03-26T12:18:42Z

services/wallet/router.go

+
+					l1GasFeeWei, _ := bridge.GetL1Fee(ctx, network, addrTo, addrFrom, token, amountIn)
+					l1GasFeeWei += l1ApprovalFee
+					gasFees.L1GasFee = weiToGwei(big.NewInt(int64(l1GasFeeWei)))


Can this be build directly instead of added?

I am not sure how @endulab has been doing it for communities but I believe they call directly:

status-go/services/wallet/api.go

Lines 396 to 399 in 590e352

func (api *API) GetSuggestedFees(ctx context.Context, chainID uint64) (*SuggestedFees, error) {

log.Debug("call to GetSuggestedFees")

return api.s.feesManager.suggestedFees(ctx, chainID)

}

if this is the case he will need to update this api endpoint but also consider this

Indeed, I use this function.

Can this be build directly instead of added?

@alaibe if we have the following params network, addrTo, addrFrom, token, amountIn on the client side, we can add a new endpoint and call it directly from the client, if that's what you meant?

Sync up with @endulab offline, will create a follow up issue

briansztamfater

LGTM, thanks for addressing this!

saledjenic force-pushed the l1-gas-price branch from d4dc656 to 4067f22 Compare March 18, 2024 08:31

saledjenic force-pushed the l1-gas-price branch 2 times, most recently from d9bd863 to a2383ca Compare March 25, 2024 15:57

saledjenic marked this pull request as ready for review March 25, 2024 15:58

saledjenic requested review from IvanBelyakoff, Khushboo-dev-cpp and alaibe and removed request for IvanBelyakoff March 25, 2024 15:58

saledjenic changed the title ~~init~~ feat: l1 gas price estimation when placing l2 transaction Mar 25, 2024

saledjenic mentioned this pull request Mar 25, 2024

fix(wallet): displaying L1 gas cost in UI status-im/status-desktop#14149

Merged

alaibe reviewed Mar 26, 2024

View reviewed changes

saledjenic force-pushed the l1-gas-price branch 2 times, most recently from 48d0dd3 to 6e30e1c Compare March 26, 2024 11:54

saledjenic requested a review from alaibe March 26, 2024 11:54

alaibe reviewed Mar 26, 2024

View reviewed changes

saledjenic force-pushed the l1-gas-price branch from 6e30e1c to 46955b1 Compare March 26, 2024 12:54

alaibe mentioned this pull request Mar 26, 2024

L1 fees for optimism communities call status-im/status-desktop#14166

Closed

saledjenic force-pushed the l1-gas-price branch from 46955b1 to daed981 Compare March 26, 2024 14:10

alaibe approved these changes Mar 26, 2024

View reviewed changes

feat: l1 gas price estimation when placing l2 transaction

1c59e85

saledjenic force-pushed the l1-gas-price branch from daed981 to 1c59e85 Compare March 26, 2024 14:15

briansztamfater approved these changes Mar 26, 2024

View reviewed changes

saledjenic merged commit 98c3be5 into develop Mar 27, 2024
7 checks passed

saledjenic deleted the l1-gas-price branch March 27, 2024 07:24

stefandunca mentioned this pull request Apr 18, 2024

feat: l1 gas price estimation when placing l2 transaction - 2.8.1 - cherry-pick #5075

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: l1 gas price estimation when placing l2 transaction #4923

feat: l1 gas price estimation when placing l2 transaction #4923

saledjenic commented Mar 14, 2024 •

edited

Loading

status-im-auto commented Mar 14, 2024 •

edited

Loading

alaibe Mar 26, 2024

alaibe Mar 26, 2024

alaibe Mar 26, 2024

alaibe left a comment

alaibe Mar 26, 2024

saledjenic Mar 26, 2024

alaibe Mar 26, 2024

alaibe Mar 26, 2024

saledjenic Mar 26, 2024

alaibe Mar 26, 2024

endulab Mar 26, 2024

saledjenic Mar 26, 2024

alaibe Mar 26, 2024

briansztamfater left a comment

	func (api API) GetSuggestedFees(ctx context.Context, chainID uint64) (SuggestedFees, error) {
	log.Debug("call to GetSuggestedFees")
	return api.s.feesManager.suggestedFees(ctx, chainID)
	}

feat: l1 gas price estimation when placing l2 transaction #4923

feat: l1 gas price estimation when placing l2 transaction #4923

Conversation

saledjenic commented Mar 14, 2024 • edited Loading

status-im-auto commented Mar 14, 2024 • edited Loading

Jenkins Builds

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alaibe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

briansztamfater left a comment

Choose a reason for hiding this comment

saledjenic commented Mar 14, 2024 •

edited

Loading

status-im-auto commented Mar 14, 2024 •

edited

Loading